Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga] Teach the constant evaluator vector/vector operators. #4861

Merged
merged 3 commits into from
Dec 12, 2023
Merged

[naga] Teach the constant evaluator vector/vector operators. #4861

merged 3 commits into from
Dec 12, 2023

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented Dec 11, 2023 •
edited
Loading

Allow constant evaluation of binary operators whose left and right
operands are both vectors.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@jimblandy jimblandy requested a review from a team as a code owner December 11, 2023 20:59
@jimblandy jimblandy added kind: feature naga Shader Translator area: naga processing Passes over IR in the middle labels Dec 11, 2023
@jimblandy jimblandy force-pushed the naga-const-eval-vector-vector branch 2 times, most recently from 5ce9925 to 101c0ae Compare December 11, 2023 21:02
@jimblandy
[naga] Change operators.wgsl to use values that matter.
62d01f5 
Change `splat` to take run-time values as arguments, to prevent
constant evaluation from boiling everything away.
@jimblandy
[naga] Teach the constant evaluator vector/vector operators.
5f140e3 
Allow constant evaluation of binary operators whose left and right
operands are both vectors.
teoxoy
teoxoy approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@teoxoy teoxoy merged commit 4b6a2d1 into gfx-rs:trunk Dec 12, 2023
27 checks passed
@jimblandy jimblandy deleted the naga-const-eval-vector-vector branch December 13, 2023 16:30
@teoxoy teoxoy added the type: enhancement New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
area: naga processing Passes over IR in the middle naga Shader Translator type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @teoxoy